Review Request 123638: Removing deprecated classes KAction and KIcon from the code base

Lucas Hermann Negri lucashnegri at gmail.com
Tue May 5 13:05:58 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123638/#review79896
-----------------------------------------------------------


Seems good to me, as this was done according to the [porting notes](https://community.kde.org/Frameworks/Porting_Notes).

- Lucas Hermann Negri


On May 5, 2015, 9:50 a.m., Minh Ngo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123638/
> -----------------------------------------------------------
> 
> (Updated May 5, 2015, 9:50 a.m.)
> 
> 
> Review request for KDE Edu, Alexander Rieder, Filipe Saraiva, and Lucas Hermann Negri.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> Removing deprecated classes KAction and KIcon from the code base
> 
> 
> Diffs
> -----
> 
>   src/assistants/advancedplot/advancedplotassistant.cpp 662aecb 
>   src/assistants/differentiate/differentiateassistant.cpp b861036 
>   src/assistants/importpackage/importpackageassistant.cpp e189a44 
>   src/assistants/integrate/integrateassistant.cpp 54cf50c 
>   src/assistants/linearalgebra/creatematrix/creatematrixassistant.cpp 7ceb653 
>   src/assistants/linearalgebra/eigenvalues/eigenvaluesassistant.cpp 77822db 
>   src/assistants/linearalgebra/eigenvectors/eigenvectorsassistant.cpp 4c6536a 
>   src/assistants/linearalgebra/invertmatrix/invertmatrixassistant.cpp c75df49 
>   src/assistants/plot2d/plot2dassistant.cpp 2852271 
>   src/assistants/plot3d/plot3dassistant.cpp 25d7c6a 
>   src/assistants/runscript/runscriptassistant.cpp a7b266f 
>   src/assistants/solve/solveassistant.cpp 5b25f90 
>   src/backends/qalculate/plotassistant/qalculateplotassistant.cpp 2e93019 
>   src/panelplugins/variablemgr/variablemanagerwidget.cpp c743a2e 
> 
> Diff: https://git.reviewboard.kde.org/r/123638/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Minh Ngo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150505/3f3296a4/attachment.html>


More information about the kde-edu mailing list