Review Request 123592: Add a score multiplying factor to the settings page
Jeremy Whiting
jpwhiting at kde.org
Sun May 3 11:13:26 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123592/#review79790
-----------------------------------------------------------
Few more things you missed.
src/qml/GamePage.qml (line 96)
<https://git.reviewboard.kde.org/r/123592/#comment54659>
Remove the line completely, no need for a commented out line like this.
src/qml/GamePage.qml (line 109)
<https://git.reviewboard.kde.org/r/123592/#comment54660>
Remove this call to calculateNetScore.
src/qml/GamePage.qml (line 618)
<https://git.reviewboard.kde.org/r/123592/#comment54661>
Remove this call also.
- Jeremy Whiting
On May 3, 2015, 4:43 a.m., Sayan Biswas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123592/
> -----------------------------------------------------------
>
> (Updated May 3, 2015, 4:43 a.m.)
>
>
> Review request for KDE Edu and Jeremy Whiting.
>
>
> Repository: khangman
>
>
> Description
> -------
>
> The score can be calculated with a multipying factor of the player's choice
>
>
> Diffs
> -----
>
> src/khangman.h d3ea4f4
> src/khangman.cpp c1c16ec
> src/qml/GamePage.qml 1c1fab9
> src/qml/MainSettingsDialog.qml 93ae6e9
>
> Diff: https://git.reviewboard.kde.org/r/123592/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sayan Biswas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150503/8b9398eb/attachment.html>
More information about the kde-edu
mailing list