Review Request 123592: Add a score multiplying factor to the settings page

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123592/#review79782
-----------------------------------------------------------


Looks good except for a few minor things that could be improved as noted.


src/khangman.h (line 130)
<https://git.reviewboard.kde.org/r/123592/#comment54644>

    I don't think this method is required. Or at least it doesn't need to be invokable and called from the QML. Just call it whenever the multiplier, wincount or losscount change in C++.



src/qml/GamePage.qml (line 389)
<https://git.reviewboard.kde.org/r/123592/#comment54641>

    Is toString() needed here. I thought QML would convert the integer to a string for us automatically.



src/qml/MainSettingsDialog.qml (line 78)
<https://git.reviewboard.kde.org/r/123592/#comment54642>

    Same here.



src/qml/MainSettingsDialog.qml (line 180)
<https://git.reviewboard.kde.org/r/123592/#comment54643>

    Same here.


- Jeremy Whiting


On May 2, 2015, 5:31 a.m., Sayan Biswas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123592/
> -----------------------------------------------------------
> 
> (Updated May 2, 2015, 5:31 a.m.)
> 
> 
> Review request for KDE Edu and Jeremy Whiting.
> 
> 
> Repository: khangman
> 
> 
> Description
> -------
> 
> The score can be calculated with a multipying factor of the player's choice
> 
> 
> Diffs
> -----
> 
>   src/khangman.h d3ea4f4 
>   src/khangman.cpp c1c16ec 
>   src/qml/GamePage.qml 1c1fab9 
>   src/qml/MainSettingsDialog.qml 93ae6e9 
> 
> Diff: https://git.reviewboard.kde.org/r/123592/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sayan Biswas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150502/e20c826a/attachment-0001.html>