Review Request 123027: Adding division activity to the maths section

[Johnny Jazeix]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123027/#review78023
-----------------------------------------------------------



src/activities/algebra_div/ActivityInfo.qml (line 1)
<https://git.reviewboard.kde.org/r/123027/#comment53465>

    You need to add a copyright (http://quickgit.kde.org/?p=gcompris.git&a=blob&h=a90222439c854ae65011e457d3ffd6a403ac1c7c&hb=7080b4140274879c44b9ff96415990e076eb1979&f=src%2Factivities%2Falgebra_plus%2FActivityInfo.qml except you put your name and email)



src/activities/algebra_div/ActivityInfo.qml (line 7)
<https://git.reviewboard.kde.org/r/123027/#comment53468>

    need to be replaced with the svg version



src/activities/algebra_div/AlgebraDiv.qml (line 3)
<https://git.reviewboard.kde.org/r/123027/#comment53466>

    you should put your name here and email (like http://quickgit.kde.org/?p=gcompris.git&a=blob&h=38598079a96b45aae1936c5162751df75eaee0f3&hb=7080b4140274879c44b9ff96415990e076eb1979&f=src%2Factivities%2Falgebra_minus%2FAlgebraMinus.qml)



src/activities/algebra_div/AlgebraDiv.qml (line 7)
<https://git.reviewboard.kde.org/r/123027/#comment53467>

    your name and email


- Johnny Jazeix


On March 18, 2015, 1:51 p.m., SAYAN BISWAS wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123027/
> -----------------------------------------------------------
> 
> (Updated March 18, 2015, 1:51 p.m.)
> 
> 
> Review request for KDE Edu and Bruno Coudoin.
> 
> 
> Repository: gcompris
> 
> 
> Description
> -------
> 
> This division activity consists of numeric divisions where a whole number answer is provided
> 
> 
> Diffs
> -----
> 
>   src/activities/activities.txt b26b7a7 
>   src/activities/algebra_by/algebra.js 6a6c732 
>   src/activities/algebra_div/ActivityInfo.qml PRE-CREATION 
>   src/activities/algebra_div/AlgebraDiv.qml PRE-CREATION 
>   src/activities/algebra_div/CMakeLists.txt PRE-CREATION 
>   src/activities/algebra_div/algebra_div.png PRE-CREATION 
>   src/core/core.js 7505d9b 
> 
> Diff: https://git.reviewboard.kde.org/r/123027/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> SAYAN BISWAS
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150324/ecec2474/attachment.html>