Review Request 123051: link kiocore private, it is not needed to link against the lib
Aleix Pol Gonzalez
aleixpol at kde.org
Thu Mar 19 15:05:29 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123051/#review77742
-----------------------------------------------------------
Ship it!
Ship It!
- Aleix Pol Gonzalez
On March 19, 2015, 4:03 p.m., Harald Sitter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123051/
> -----------------------------------------------------------
>
> (Updated March 19, 2015, 4:03 p.m.)
>
>
> Review request for KDE Edu.
>
>
> Repository: libkeduvocdocument
>
>
> Description
> -------
>
> kiocore is used for file operations into the cpp, so it does not need to
> be part of the interface link list
>
>
> Diffs
> -----
>
> keduvocdocument/CMakeLists.txt 6eeba12a8404f4336bec23b26133c7e310819601
>
> Diff: https://git.reviewboard.kde.org/r/123051/diff/
>
>
> Testing
> -------
>
> make && make install && make test
>
> also tested building khangman against it, also worked fine
>
>
> Thanks,
>
> Harald Sitter
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150319/f3ce1a73/attachment.html>
More information about the kde-edu
mailing list