Review Request 123043: explicitly find_package sonnet

Albert Astals Cid aacid at kde.org
Thu Mar 19 10:12:45 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123043/#review77725
-----------------------------------------------------------


Actaully since it seems unused i'd prefer if you remove it from the link line

- Albert Astals Cid


On mar. 19, 2015, 8:53 a.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123043/
> -----------------------------------------------------------
> 
> (Updated mar. 19, 2015, 8:53 a.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: khangman
> 
> 
> Description
> -------
> 
> khangman target explicitly links SonnetCore, so we should explicitly look
> for the Sonnet cmake package or the build fails with tightly dependent
> frameworks
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d0c1e66a2625a5b2ac6002a69af81be858eac80c 
> 
> Diff: https://git.reviewboard.kde.org/r/123043/diff/
> 
> 
> Testing
> -------
> 
> make && make install && make test
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150319/0dbefb99/attachment.html>


More information about the kde-edu mailing list