Review Request 122969: Adding division activity to the math section

[Bruno Coudoin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122969/#review77656
-----------------------------------------------------------



src/activities/algebra_by/algebra.js
<https://git.reviewboard.kde.org/r/122969/#comment53316>

    Why do you add a size parameter as it is always 2.



src/activities/algebra_by/algebra.js
<https://git.reviewboard.kde.org/r/122969/#comment53317>

    Why changing firstOperandVal by operands[0]


- Bruno Coudoin


On mars 16, 2015, 4:43 après-midi, SAYAN BISWAS wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122969/
> -----------------------------------------------------------
> 
> (Updated mars 16, 2015, 4:43 après-midi)
> 
> 
> Review request for KDE Edu and Bruno Coudoin.
> 
> 
> Repository: gcompris
> 
> 
> Description
> -------
> 
> The division activity cosists of numeric divisions where the I have actually neglected the decimal part and considered the rest keeping in mind that the game is meant for kids.
> 
> 
> Diffs
> -----
> 
>   src/activities/activities.txt b26b7a7 
>   src/activities/algebra_by/Algebra.qml d6f261e 
>   src/activities/algebra_by/algebra.js 6a6c732 
>   src/activities/algebra_div/ActivityInfo.qml PRE-CREATION 
>   src/activities/algebra_div/AlgebraDiv.qml PRE-CREATION 
>   src/activities/algebra_div/CMakeLists.txt PRE-CREATION 
>   src/activities/algebra_div/algebra_div.png PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122969/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> SAYAN BISWAS
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150317/c33826ce/attachment-0001.html>