Review Request 122889: Explicitly look for KArchive

Andreas Cord-Landwehr cordlandwehr at kde.org
Tue Mar 10 12:17:16 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122889/#review77252
-----------------------------------------------------------

Ship it!


Ship It!

- Andreas Cord-Landwehr


On March 10, 2015, 12:07 p.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122889/
> -----------------------------------------------------------
> 
> (Updated March 10, 2015, 12:07 p.m.)
> 
> 
> Review request for KDE Edu and Andreas Cord-Landwehr.
> 
> 
> Repository: rocs
> 
> 
> Description
> -------
> 
> KF5::Archive is used as a target, but not explicitly dragged in. Whichever
> framework previously dragged it in as depedendency does not do so anymore in
> git master, so take the safe route and make explicitly sure that KArchive is present.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 0ee8a2258fb09fc1ea663e6cf94f643eabde382d 
> 
> Diff: https://git.reviewboard.kde.org/r/122889/diff/
> 
> 
> Testing
> -------
> 
> make && make -j && sudo make install && ctest; echo $?
> 0
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150310/ddd71db4/attachment.html>


More information about the kde-edu mailing list