Review Request 122771: method to ignore extra white spaces.

[Inge Wallin]

> On March 2, 2015, 2:21 p.m., Inge Wallin wrote:
> > src/practice/writtenpracticevalidator.cpp, line 94
> > <https://git.reviewboard.kde.org/r/122771/diff/1/?file=352712#file352712line94>
> >
> >     This is a strange change...  Why?
> 
> ankit wagadre wrote:
>     "answer" is used to pass string in the rest of code.I used it to pass modified string and changed the original one.

That's not what I meant. I meant why was the name shortened from 'answer' to 'answr'?


> On March 2, 2015, 2:21 p.m., Inge Wallin wrote:
> > src/practice/writtenpracticevalidator.cpp, lines 136-145
> > <https://git.reviewboard.kde.org/r/122771/diff/1/?file=352712#file352712line136>
> >
> >     First of all, check out QString::simplified().  Second, You are only supposed to remove duplicate spaces, not every space.
> 
> ankit wagadre wrote:
>     QString::simplified() is not necessary.its not removing all white spaces there are few conditions.For example
>     "hello world" != "helloworld" but "hello, world" or "hello , world" == "hello,world"

Yes, that is true.  But QString::simplified() doesn't remove all spaces, only duplicate ones.  So I think that whatever you want to do next, starting out with simplified() is a good idea.


- Inge


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122771/#review76890
-----------------------------------------------------------


On March 2, 2015, 11:53 a.m., ankit wagadre wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122771/
> -----------------------------------------------------------
> 
> (Updated March 2, 2015, 11:53 a.m.)
> 
> 
> Review request for KDE Edu and Inge Wallin.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> Method to ignore extra white spaces.And some corrections.
> 
> 
> Diffs
> -----
> 
>   src/practice/writtenbackendmode.cpp 23b0260 
>   src/practice/writtenpracticevalidator.h ee99b25 
>   src/practice/writtenpracticevalidator.cpp 714ce01 
> 
> Diff: https://git.reviewboard.kde.org/r/122771/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> ankit wagadre
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150308/48007296/attachment-0001.html>