Review Request 122771: method to ignore extra white spaces.

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122771/#review76890
-----------------------------------------------------------


Still some things to take care of...  :)


src/practice/writtenpracticevalidator.cpp
<https://git.reviewboard.kde.org/r/122771/#comment52895>

    This is a strange change...  Why?



src/practice/writtenpracticevalidator.cpp
<https://git.reviewboard.kde.org/r/122771/#comment52896>

    First of all, check out QString::simplified().  Second, You are only supposed to remove duplicate spaces, not every space.



src/practice/writtenpracticevalidator.cpp
<https://git.reviewboard.kde.org/r/122771/#comment52897>

    Now you are mixing two different bugs in the same review. This has nothing to do with whitespace, does it?


- Inge Wallin


On March 2, 2015, 11:53 a.m., ankit wagadre wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122771/
> -----------------------------------------------------------
> 
> (Updated March 2, 2015, 11:53 a.m.)
> 
> 
> Review request for KDE Edu and Inge Wallin.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> Method to ignore extra white spaces.And some corrections.
> 
> 
> Diffs
> -----
> 
>   src/practice/writtenbackendmode.cpp 23b0260 
>   src/practice/writtenpracticevalidator.h ee99b25 
>   src/practice/writtenpracticevalidator.cpp 714ce01 
> 
> Diff: https://git.reviewboard.kde.org/r/122771/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> ankit wagadre
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150302/5d96fdd7/attachment.html>