Review Request 124025: Port ImageExporter Away from KImageIO

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124025/#review81305
-----------------------------------------------------------

Ship it!


The port seems correct.

Too bad about the QString/QByteArray mismatch in the Qt APIs indeed :(

BTW this is all documented in kdelibs4support/src/kio/kimageio.h
But I see a DOXYGEN_SHOULD_SKIP_THIS which is indeed a bad idea for reading deprecation notes.
I have removed that, we'll see if http://api.kde.org/frameworks-api/frameworks5-apidocs/kdelibs4support/html/namespaceKImageIO.html improves next time it gets re-generated.

- David Faure


On June 6, 2015, 7:05 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124025/
> -----------------------------------------------------------
> 
> (Updated June 6, 2015, 7:05 p.m.)
> 
> 
> Review request for KDE Edu and David Faure.
> 
> 
> Repository: kig
> 
> 
> Description
> -------
> 
> This code is based on QImageWriter.
> 
> I am guessing all of this since there's nothing documented in the porting notes about KImageIO.
> 
> 
> Diffs
> -----
> 
>   filters/exporter.cc a4a37d11bb6ed1c18d59bcbc681dc475cb51c652 
> 
> Diff: https://git.reviewboard.kde.org/r/124025/diff/
> 
> 
> Testing
> -------
> 
> 1. Create some objects
> 2. Go to File -> Export To -> Image...
> 3. Save an image
> 
> Dialog filters should work and there should be a couple of image formats for you to choose.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150608/8feeb775/attachment.html>