Review Request 123968: Simplify Finding GSL in CMake

[Stefan Gerlach]

> On June 1, 2015, 7:05 a.m., Raphael Kubo da Costa wrote:
> > Sorry for stumbling upon this RR by chance :-)
> > 
> > What can cause a problem for OS X as well as systems such as FreeBSD is that now `GSL_LIBRARIES` is going to be something like `-lfoo` instead of `-l/full/path/to/libfoo.so` so if `/full/path/to` is not in the default linker path linking against GSL will fail unless you make CMake aware of `GSL_LIBRARY_DIRS`.
> > 
> > If you are willing to bump CMake's minimum required version to 2.8 (or test it against 2.6), upstream CMake now has a FindGSL.cmake which you could import and use in case it is not present in CMake itself if your goal is to just simplify `CMakeLists.txt`.
> 
> David Narváez wrote:
>     Oh, didn't know about FindGSL.cmake. If the maintainer is OK with bumping the version to 2.8 I will prepare a patch that uses that.
> 
> Stefan Gerlach wrote:
>     Mimimum version of CMake for LabPlot is now 2.8.10. Please update your patch accordingly.

FindGSL.cmake is only available in the latest version CMake 3.2. We could deliver this module for supporting older version of CMake.


- Stefan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123968/#review81032
-----------------------------------------------------------


On June 7, 2015, 5:10 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123968/
> -----------------------------------------------------------
> 
> (Updated June 7, 2015, 5:10 a.m.)
> 
> 
> Review request for KDE Edu and Marko Käning.
> 
> 
> Repository: labplot
> 
> 
> Description
> -------
> 
> Use the module provided by CMake. Setting compile definitions HAVE_GSL and GSL_VERSION has no effect in the code so I removed them.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt aff47951115403da86c8bfcfc2985da974aa7c0b 
> 
> Diff: https://git.reviewboard.kde.org/r/123968/diff/
> 
> 
> Testing
> -------
> 
> Compiled with make VERBOSE=1 to see the compile commands. I am not sure if this still works in the OSX configuration, Marko?
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150607/bb7aa943/attachment-0001.html>