Review Request 123919: Move the Option to Save with Backend Extension to "Save As Plaintext"

[David Narváez]

> On June 3, 2015, 1:43 p.m., Filipe Saraiva wrote:
> > I would like to see this feature working yet. I don't know if remove the feature is the best for it.
> > I will talk with Alex Rieder (the official Cantor maintainer) about it.
> > 
> > Thanks!
> 
> Filipe Saraiva wrote:
>     Can you try to fix the feature? =)

The only thing a backend's script extension provides to the CantorPart is a script *filter* so in order for CantorPart to know whether the user selected a filename ending on the script *file extension* we would have to parse the filter to extract the actual file extension and then check with QString::endsWith.

I think that's doable but the code is really ugly and it is all because this feature was not thought for saving scripts. Save as Plaintext, on the other hand, does precisely that, so I really think we should move this from Save As.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123919/#review81123
-----------------------------------------------------------


On May 27, 2015, 11:48 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123919/
> -----------------------------------------------------------
> 
> (Updated May 27, 2015, 11:48 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Bugs: 348338
>     http://bugs.kde.org/show_bug.cgi?id=348338
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> The "Save (As)" options do not know of anything but Cantor worksheets so
> it is better to move saving as a script to the "Save As Plaintext"
> option.
> 
> 
> Diffs
> -----
> 
>   src/cantor_part.cpp 84a7ca96dfae836717240e2377b02656aa4b8999 
> 
> Diff: https://git.reviewboard.kde.org/r/123919/diff/
> 
> 
> Testing
> -------
> 
> See steps to reproduce bug 348338.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150603/4543062b/attachment.html>