Review Request 122081: Generate activities qrc files in the build directory

Johnny Jazeix jazeix at gmail.com
Tue Jun 2 20:06:39 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122081/#review81095
-----------------------------------------------------------


Works fine using Qt5.5.0 beta.
As we can't set the minimum Qt version to 5.4.2, we need to guard the changes between if(${Qt5_VERSION} STRGREATER "5.4.1") endif(). So maybe letting the *.qrc in the .gitignore for now.
Also, it does not work on Windows (console stays locked at [  1%] Generating ../../share/gcompris-qt/rcc/activities.rcc and rcc is running at 15-30% of cpu). Maybe the redirection?
I don't know much but I can take a look if necessary.

- Johnny Jazeix


On Jan. 20, 2015, 3:54 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122081/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2015, 3:54 a.m.)
> 
> 
> Review request for KDE Edu and Bruno Coudoin.
> 
> 
> Repository: gcompris
> 
> 
> Description
> -------
> 
> Just had to compile from a user to another and saw this issue. It's quite straightforward, I don't think it will be a problem.
> 
> 
> Diffs
> -----
> 
>   .gitignore be9278f 
>   cmake/rcc.cmake 15c5cee 
> 
> Diff: https://git.reviewboard.kde.org/r/122081/diff/
> 
> 
> Testing
> -------
> 
> It works as it used to.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150602/bd46077f/attachment.html>


More information about the kde-edu mailing list