Review Request 123984: Port Away from KLocale in coordinate_system.cpp

Aleix Pol Gonzalez aleixpol at kde.org
Tue Jun 2 13:06:32 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123984/#review81075
-----------------------------------------------------------


+1

- Aleix Pol Gonzalez


On June 2, 2015, 2:52 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123984/
> -----------------------------------------------------------
> 
> (Updated June 2, 2015, 2:52 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: kig
> 
> 
> Description
> -------
> 
> This particular class made heavy use of KLocale so I want to make sure I
> got this one right.
> 
> 
> Diffs
> -----
> 
>   misc/coordinate_system.cpp 3095ea692e5ae91f4793b95d3408170a872a0986 
> 
> Diff: https://git.reviewboard.kde.org/r/123984/diff/
> 
> 
> Testing
> -------
> 
> 1. Create a point, then right click and set the coordinates
> 2. Change the zoom area with View->Select Zoom Area
> 
> In all of these cases the coordinates you see should be properly formatted according to your locale (e.g., decimal points, signs) and all your inputs should be validated properly.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150602/bc2fcab2/attachment.html>


More information about the kde-edu mailing list