Review Request 123968: Simplify Finding GSL in CMake

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123968/#review81032
-----------------------------------------------------------


Sorry for stumbling upon this RR by chance :-)

What can cause a problem for OS X as well as systems such as FreeBSD is that now `GSL_LIBRARIES` is going to be something like `-lfoo` instead of `-l/full/path/to/libfoo.so` so if `/full/path/to` is not in the default linker path linking against GSL will fail unless you make CMake aware of `GSL_LIBRARY_DIRS`.

If you are willing to bump CMake's minimum required version to 2.8 (or test it against 2.6), upstream CMake now has a FindGSL.cmake which you could import and use in case it is not present in CMake itself if your goal is to just simplify `CMakeLists.txt`.


CMakeLists.txt (line 5)
<https://git.reviewboard.kde.org/r/123968/#comment55490>

    AFAIR, this form has been deprecated and the recommended version is `find_package(PkgConfig)`.



CMakeLists.txt (line 23)
<https://git.reviewboard.kde.org/r/123968/#comment55491>

    Is this also going to set `GSL_CBLAS_LIBRARIES`?


- Raphael Kubo da Costa


On May 31, 2015, 9:17 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123968/
> -----------------------------------------------------------
> 
> (Updated May 31, 2015, 9:17 p.m.)
> 
> 
> Review request for KDE Edu and Marko Käning.
> 
> 
> Repository: labplot
> 
> 
> Description
> -------
> 
> Use PkgConfig and basic string manipulation to find info about the GSL
> installation and whether or not it has CBLAS.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt aff47951115403da86c8bfcfc2985da974aa7c0b 
> 
> Diff: https://git.reviewboard.kde.org/r/123968/diff/
> 
> 
> Testing
> -------
> 
> Compiled with make VERBOSE=1 to see the compile commands. I am not sure if this still works in the OSX configuration, Marko?
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150601/989f2a83/attachment-0001.html>