Review Request 122081: Generate activities qrc files in the build directory

[Johnny Jazeix]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122081/#review82721
-----------------------------------------------------------

Ship it!


After these fixes, it's good for me (tested on windows and linux with Qt5.5, both cases work).
Thanks for the patch.


.gitignore 
<https://git.reviewboard.kde.org/r/122081/#comment57043>

    I would not remove this as some developers using Qt < 5.4.2 may commit these files by mistake.



cmake/rcc.cmake (line 37)
<https://git.reviewboard.kde.org/r/122081/#comment57042>

    you forgot ${CREATED_QRC} at the end.


- Johnny Jazeix


On July 20, 2015, 11:27 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122081/
> -----------------------------------------------------------
> 
> (Updated July 20, 2015, 11:27 a.m.)
> 
> 
> Review request for KDE Edu, Bruno Coudoin and Johnny Jazeix.
> 
> 
> Repository: gcompris
> 
> 
> Description
> -------
> 
> Just had to compile from a user to another and saw this issue. It's quite straightforward, I don't think it will be a problem.
> 
> 
> Diffs
> -----
> 
>   .gitignore 2606c91 
>   cmake/rcc.cmake aa64f1c 
> 
> Diff: https://git.reviewboard.kde.org/r/122081/diff/
> 
> 
> Testing
> -------
> 
> It works as it used to.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150720/1709d456/attachment.html>