Review Request 122263: Fixing export cws files

Filipe Saraiva filipe at kde.org
Sat Jan 31 10:29:38 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122263/#review75064
-----------------------------------------------------------

Ship it!


Ship It!

- Filipe Saraiva


On Jan. 26, 2015, 3:22 p.m., Minh Ngo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122263/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2015, 3:22 p.m.)
> 
> 
> Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.
> 
> 
> Bugs: 343002
>     http://bugs.kde.org/show_bug.cgi?id=343002
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> file_name variable is like that "/home/username/blahblahblah/". This kind of file path is not acceptable for QUrl. you need to add at least a prefix file:// before it. To solve this problem we have to replace QUrl constructor by QUrl::fromLocalFile instead.
> 
> 
> Diffs
> -----
> 
>   src/cantor_part.cpp c809be2 
> 
> Diff: https://git.reviewboard.kde.org/r/122263/diff/
> 
> 
> Testing
> -------
> 
> 1. Create a python 2 worksheet
> 2. Type print 1
> 3. File -> Save As
> 4. Save somewhere (in my case ~/)
> 5. Check that this file exists.
> 
> 
> Thanks,
> 
> Minh Ngo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150131/2ec21557/attachment.html>


More information about the kde-edu mailing list