Review Request 122297: kanagram: Sayan's SoK with some improvements, need a second set of eyes

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122297/#review74987
-----------------------------------------------------------

Ship it!


Works well. no glitches.  Only problem is that it's a little difficult to understand the first time that you can click on the characters in the half-finished word to undo them.

- Inge Wallin


On Jan. 28, 2015, 11:39 p.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122297/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2015, 11:39 p.m.)
> 
> 
> Review request for KDE Edu, Inge Wallin, Rahul Chowdhury, and Souvik  Das.
> 
> 
> Repository: kanagram
> 
> 
> Description
> -------
> 
> I took Sayan's SoK patch and updated it to work and added keyboard handling. It works pretty well in my opinion, but I wanted to get a second opinion before merging to master. This is what's on the letterbuttons branch in kanagram currently if you'd like to check it out from there to build and try it.
> 
> It makes kanagram's letters buttons that are clickable to move up and down to create the answer from. It also adds keyboard handling like the previous lineinput worked. typing keys, backspace, etc. work fine.
> 
> Enter isn't handled since if all the letters aren't used it's obviously going to be wrong. Solution checking is only done when all letters are used up this way. Makes it somewhat easier, imo.
> 
> 
> Diffs
> -----
> 
>   src/kanagramgame.cpp 3d50cc7 
>   src/ui/Blackboard.qml ac5f356 
>   src/ui/LetterButton.qml PRE-CREATION 
>   src/ui/main.qml ab52c34 
>   src/kanagramgame.h a236d47 
> 
> Diff: https://git.reviewboard.kde.org/r/122297/diff/
> 
> 
> Testing
> -------
> 
> Builds, runs, plays fine in my testing.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150129/cec132cf/attachment.html>