Review Request 122248: Fixing the crash during autocompletion

[Minh Ngo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122248/
-----------------------------------------------------------

(Updated Jan. 25, 2015, 4:59 p.m.)


Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.


Changes
-------

Upd diff


Bugs: 342888
    http://bugs.kde.org/show_bug.cgi?id=342888


Repository: cantor


Description
-------

Fixes the crash during autocompletion.

This crash happened before possibly because you didn't select any item from the completion list before pressing '.'. And then because of some logic it decided that you don't need m_completionObject anymore and delete it.

Detailed stack trace is in the bug ticket.

I'm selecting the first item after pressing tab to avoid this problem. Looks like all is working now like an user expects.


Diffs (updated)
-----

  src/commandentry.cpp 7b7c657 

Diff: https://git.reviewboard.kde.org/r/122248/diff/


Testing
-------

1. Select some backend (for example, Python 2);
2. Type "num" (without ") and press TAB;
3. Press "." (without ");


Thanks,

Minh Ngo

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150125/c7532de4/attachment.html>