Review Request 122186: Update deprecated code for accessing libkeduvocdocument.
Inge Wallin
inge at lysator.liu.se
Wed Jan 21 18:05:01 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122186/#review74491
-----------------------------------------------------------
Ship it!
Looks good.
Apply to the Applications/14.12 branch and then, if you like, merge to master.
If you don't want to do that now, that's ok, we can merge it later with later patches.
Good work!
- Inge Wallin
On Jan. 21, 2015, 6:56 p.m., Rahul Chowdhury wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122186/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2015, 6:56 p.m.)
>
>
> Review request for KDE Edu, Inge Wallin and Jeremy Whiting.
>
>
> Repository: parley
>
>
> Description
> -------
>
> Change the function calling statements in parley to update the code according to the new definitions in libkeduvocdocument.
>
>
> Diffs
> -----
>
> src/collection/entryfilter.cpp 74614fe
> src/editor/comparisonwidget.cpp d607bec
> src/practice/comparisonbackendmode.cpp 1d27e84
> src/scripts/scripting/translation.h 9ca3b82
>
> Diff: https://git.reviewboard.kde.org/r/122186/diff/
>
>
> Testing
> -------
>
> It builds with no errors/warnings.
>
>
> Thanks,
>
> Rahul Chowdhury
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150121/ca4314e3/attachment.html>
More information about the kde-edu
mailing list