Review Request 122166: KEduVocDocument: Mark document as dirty when grades are removed.

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122166/#review74389
-----------------------------------------------------------

Ship it!


Looks good to me. May want to add an assertion as noted below though.


keduvocdocument/keduvoccontainer.cpp
<https://git.reviewboard.kde.org/r/122166/#comment51609>

    I see it's not likely to happen and would be a bug, but shouldn't we check for NULL here? or add a Q_ASSERT since we assume not having an m_document here is a bug.


- Jeremy Whiting


On Jan. 20, 2015, 2:18 a.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122166/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2015, 2:18 a.m.)
> 
> 
> Review request for KDE Edu and Jeremy Whiting.
> 
> 
> Repository: libkdeedu
> 
> 
> Description
> -------
> 
> This solves https://bugs.kde.org/show_bug.cgi?id=341139
> 
> Note that commenting out the test in the cmake file is not supposed to be in there. It's just that I had a link error and this was a quick and dirty way to solve that for the moment. It's not actually part of the patch.
> 
> 
> Diffs
> -----
> 
>   keduvocdocument/keduvoccontainer.cpp a7d7b3e 
>   keduvocdocument/keduvocdocument.cpp 6ae7e43 
>   keduvocdocument/keduvoclesson.h 967470f 
>   keduvocdocument/keduvoclesson.cpp 2691ce4 
>   keduvocdocument/CMakeLists.txt af0bdc2 
>   keduvocdocument/keduvoccontainer.h 50a7165 
> 
> Diff: https://git.reviewboard.kde.org/r/122166/diff/
> 
> 
> Testing
> -------
> 
> Tested with an unpatched Parley. Works for both recursive and non-recursive versions of the action.
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150120/aa216837/attachment.html>