Review Request 122081: Generate activities qrc files in the build directory

[Bruno Coudoin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122081/#review74161
-----------------------------------------------------------


Hi,

We agree that the qrc should be generated in the build directory and we tried hard to do this.

And sadly your patch does not work either. At least the "--root ${CMAKE_CURRENT_SOURCE_DIR}" should be placed on the "COMMAND ${Qt5Core_RCC_EXECUTABLE}" line. But even with this it

The qrc are generated but not the rcc which fails with the error:
[  1%] Generating ../../share/gcompris-qt/rcc/activities.rcc
RCC: Error in '/home/bdoin/Projets/gcompris/gcompris-kde/build/src/activities/activities.qrc': Cannot find file 'activities.txt'

Our understanding is that Qt's rcc requires the source file to be locate in the dir of the qrc in order to have the rcc creation to work.

If we are right, it maybe better to fix rcc itself to add an option to specify the source directory when it is different than the qrc location (in --binary mode)

- Bruno Coudoin


On jan. 16, 2015, 1 matin, Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122081/
> -----------------------------------------------------------
> 
> (Updated jan. 16, 2015, 1 matin)
> 
> 
> Review request for KDE Edu and Bruno Coudoin.
> 
> 
> Repository: gcompris
> 
> 
> Description
> -------
> 
> Just had to compile from a user to another and saw this issue. It's quite straightforward, I don't think it will be a problem.
> 
> 
> Diffs
> -----
> 
>   .gitignore be9278f 
>   cmake/rcc.cmake 15c5cee 
> 
> Diff: https://git.reviewboard.kde.org/r/122081/diff/
> 
> 
> Testing
> -------
> 
> It works as it used to.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150116/ab62d27e/attachment.html>