Review Request 121970: Fixing the crash when trying to close the script editor

[Alexander Rieder]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121970/#review73744
-----------------------------------------------------------

Ship it!


Ship It!

- Alexander Rieder


On Jan. 10, 2015, 5:15 nachm., Minh Ngo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121970/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2015, 5:15 nachm.)
> 
> 
> Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.
> 
> 
> Bugs: 342696
>     http://bugs.kde.org/show_bug.cgi?id=342696
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> Fixes the crash when trying to close the script editor.
> 
> When an user is closing the script editor, destroyed() signal of the class ScriptEditorWidget is called, it will call CantorPart::scriptEditorClosed that will call CantorPart::showScriptEditor that will try to delete explicitly the initial caller (the ScriptEditorWidget), that was the cause of the crash.
> 
> 
> Diffs
> -----
> 
>   src/cantor_part.h fa7fd95 
>   src/cantor_part.cpp d22c13c 
> 
> Diff: https://git.reviewboard.kde.org/r/121970/diff/
> 
> 
> Testing
> -------
> 
> 1. Run cantor
> 2. View -> Show Script Editor
> 3. Close Script Editor
> 4. Check that the check box from the "Show Script Editor" is in the unchecked state and the ScriptEditorWidget object has been destroyed successfully.
> 
> 
> Thanks,
> 
> Minh Ngo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150111/b1f3eacb/attachment.html>