Review Request 119141: make the stylesheet file shorter to avoid the 'memory-exhausted' error.

David Narváez david.narvaez at computer.org
Thu Jan 8 02:59:34 UTC 2015



> On Nov. 9, 2014, 10:05 p.m., Albert Astals Cid wrote:
> > Ping review?
> 
> Albert Astals Cid wrote:
>     Ping?

This patch has a longer story: this is to hack around a bug deep in Qt and I am waiting for me to fix the bug or give up and use this patch... haven't decided yet.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119141/#review70133
-----------------------------------------------------------


On July 6, 2014, 8 a.m., Aniket Anvit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119141/
> -----------------------------------------------------------
> 
> (Updated July 6, 2014, 8 a.m.)
> 
> 
> Review request for KDE Edu and David Narváez.
> 
> 
> Repository: kig
> 
> 
> Description
> -------
> 
> I added a QMap to the KigFilterGeogebra class which maps the Geogebra Object names to the corresponding kig names. Then we can make the stylesheet file much shorter and avoid the 'memory-exhausted' error.
> 
> I haven't filled the namesMap for all the objects. If you like this approach we can move ahead with this.
> 
> 
> Diffs
> -----
> 
>   filters/geogebra-filter.h 1b2b416 
>   filters/geogebra-filter.cpp 53c9253 
>   filters/geogebra.xsl a0809da 
> 
> Diff: https://git.reviewboard.kde.org/r/119141/diff/
> 
> 
> Testing
> -------
> 
> I tested it with an ellipse and a Conic-5-point objects. OK!!
> 
> 
> Thanks,
> 
> Aniket Anvit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150108/11f1f33c/attachment.html>


More information about the kde-edu mailing list