Review Request 121906: Add tooltips.

Jeremy Whiting jpwhiting at kde.org
Wed Jan 7 21:45:43 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121906/#review73420
-----------------------------------------------------------


I like the tooltips, but the rest of the changes (removing tons of semicolons) are probably not needed. I know qml can use semicolons or not, but it helps readability to leave them in at least in the code (functions) and such.
I would remove "Click here to" from the button tooltips though, just say what it will do, no need to say click here

- Jeremy Whiting


On Jan. 7, 2015, 2:38 p.m., Rahul Chowdhury wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121906/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2015, 2:38 p.m.)
> 
> 
> Review request for KDE Edu and Jeremy Whiting.
> 
> 
> Repository: khangman
> 
> 
> Description
> -------
> 
> Added some tooltips to the various ToolButton elements in GamePage.
> 
> 
> Diffs
> -----
> 
>   src/qml/GamePage.qml b74abab 
> 
> Diff: https://git.reviewboard.kde.org/r/121906/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rahul Chowdhury
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150107/1580b850/attachment.html>


More information about the kde-edu mailing list