Review Request 121883: Add About button

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121883/#review73279
-----------------------------------------------------------


Looks good except for these few things noted. Fix them and it works fine.


src/khangman.h
<https://git.reviewboard.kde.org/r/121883/#comment50956>

    These need to be moved up to public slots for them to be able to be called from GamePage.qml.



src/main.cpp
<https://git.reviewboard.kde.org/r/121883/#comment50957>

    No need to add this here.



src/qml/GamePage.qml
<https://git.reviewboard.kde.org/r/121883/#comment50958>

    I would put the About button left of the next word button.



src/qml/GamePage.qml
<https://git.reviewboard.kde.org/r/121883/#comment50959>

    need to use the same case as the slot name or it won't work. showAboutKHangMan()


- Jeremy Whiting


On Jan. 6, 2015, 9:42 a.m., Rahul Chowdhury wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121883/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2015, 9:42 a.m.)
> 
> 
> Review request for KDE Edu and Jeremy Whiting.
> 
> 
> Repository: khangman
> 
> 
> Description
> -------
> 
> The KAboutData information is displayed when the About button is clicked
> 
> 
> Diffs
> -----
> 
>   src/khangman.h 9d54cd3 
>   src/khangman.cpp f7cb34d 
>   src/main.cpp 09d8799 
>   src/qml/GamePage.qml 5ba385c 
> 
> Diff: https://git.reviewboard.kde.org/r/121883/diff/
> 
> 
> Testing
> -------
> 
> It is compiling fine, but the ToolButton is not visible in the bottom statusbar of GamePage. Can you please try the patch there once?
> 
> 
> Thanks,
> 
> Rahul Chowdhury
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150106/cf0b87c9/attachment-0001.html>