Review Request 121883: Add About button

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121883/#review73276
-----------------------------------------------------------

Ship it!


This looks close. Does it run there? I would remove the AboutDialog from GamePage.qml since that's not needed/used, and remove #include <KAboutData> from khangman.h. Otherwise go for it.

- Jeremy Whiting


On Jan. 6, 2015, 9:32 a.m., Rahul Chowdhury wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121883/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2015, 9:32 a.m.)
> 
> 
> Review request for KDE Edu and Jeremy Whiting.
> 
> 
> Repository: khangman
> 
> 
> Description
> -------
> 
> The KAboutData information is displayed when the About button is clicked
> 
> 
> Diffs
> -----
> 
>   src/khangman.h 9d54cd3 
>   src/khangman.cpp f7cb34d 
>   src/main.cpp 09d8799 
>   src/qml/GamePage.qml 5ba385c 
> 
> Diff: https://git.reviewboard.kde.org/r/121883/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rahul Chowdhury
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150106/e39298ce/attachment.html>