Review Request 121778: Bug Fix 342020 : When hover on legends of Periodic Table the elements belonging to that group fade out.

Shalin Shah shalinshah1993 at gmail.com
Fri Jan 2 17:48:49 UTC 2015



> On Jan. 2, 2015, 12:37 p.m., Etienne Rebetez wrote:
> > Yes you are right, I forgot about the states...
> 
> Shalin Shah wrote:
>     Hey but how can I ship it? Sorry, unaware about it? Aren't you supposed to do that?
> 
> Etienne Rebetez wrote:
>     I just pushed the change. Thanks again. 
>     If you want to further contribute to kde, you cold ask for a git write access. Put me as reference. Then you can commit your own patches.

Hey, that is good suggestion since I'm looking forward to some hefty contribution. Can you tell me where should I ask for git write access? Any links or something?


- Shalin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121778/#review72939
-----------------------------------------------------------


On Jan. 2, 2015, 2:23 p.m., Shalin Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121778/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2015, 2:23 p.m.)
> 
> 
> Review request for KDE Edu and Etienne Rebetez.
> 
> 
> Repository: kalzium
> 
> 
> Description
> -------
> 
> Fixed the color scheme of elements in periodic table when hovered over the legend of their group.
> 
> 
> Diffs
> -----
> 
>   src/legendwidget.cpp b0a7ba0 
> 
> Diff: https://git.reviewboard.kde.org/r/121778/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Shalin Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150102/36b2de5c/attachment.html>


More information about the kde-edu mailing list