Review Request 121778: Bug Fix 342020 : When hover on legends of Periodic Table the elements belonging to that group fade out.

[Jeremy Whiting]

> On Jan. 2, 2015, 6:54 a.m., Albert Astals Cid wrote:
> > src/legendwidget.cpp, line 160
> > <https://git.reviewboard.kde.org/r/121778/diff/3/?file=337758#file337758line160>
> >
> >     Wow, why these .operator== calls and not just use == ¿?
> 
> Etienne Rebetez wrote:
>     I used this because we compare QColor objects. However, like you say, it seems to work just with a simple operator.
>     Is there a reason to change this?
> 
> Albert Astals Cid wrote:
>     No reason other than it looks very weird :D
> 
> Albert Astals Cid wrote:
>     Also, any reason you did commit this to master only and not Applications/14.12 and then merged to master?
> 
> Etienne Rebetez wrote:
>     No. Isn't master always the newest branch? 14.12 looks old no? 
>     I probaly did get the memo ;)

Master is what will be released at the next major release (15.04 most likely) but bug fixes should also go to Applications/14.12 (i.e. the stable branch) so they will go in the next minor release (14.12.1 or whatever it will be called) If this is a bugfix please cherry-pick it to Applications/14.12 branch also.


- Jeremy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121778/#review72943
-----------------------------------------------------------


On Jan. 2, 2015, 7:23 a.m., Shalin Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121778/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2015, 7:23 a.m.)
> 
> 
> Review request for KDE Edu and Etienne Rebetez.
> 
> 
> Repository: kalzium
> 
> 
> Description
> -------
> 
> Fixed the color scheme of elements in periodic table when hovered over the legend of their group.
> 
> 
> Diffs
> -----
> 
>   src/legendwidget.cpp b0a7ba0 
> 
> Diff: https://git.reviewboard.kde.org/r/121778/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Shalin Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150102/77c5d937/attachment-0001.html>