Review Request 121758: Kalzium : Porting to KF5 CMake built

[anu mittal]

Yes,Indeed. I will share the updated c++ code as well, as and when I am
done with it.

On Fri, Jan 2, 2015, 8:00 AM Aleix Pol Gonzalez <aleixpol at kde.org> wrote:

>   This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121758/
>
> On December 30th, 2014, 11:17 p.m. UTC, *Aleix Pol Gonzalez* wrote:
>
> There's plenty of new files, I think these are just renames, make sure the patch recognizes the other ones as removed. Also you can use the --find-copies-harder (or -M80) for better detection of those.
>
> Also most of this won't ever work, like I pointed out in a couple of places. Can you go through the C++ code as well? I don't think it's different steps really.
>
>  On December 31st, 2014, 2:08 p.m. UTC, *Anu Mittal* wrote:
>
> Yes,I will be working on c++ code too.
>
>  Then please do, I don't think it makes much sense committing this, just yet.
>
>
> - Aleix
>
> On December 30th, 2014, 6:13 p.m. UTC, Anu Mittal wrote:
>   Review request for KDE Edu and Aleix Pol Gonzalez.
> By Anu Mittal.
>
> *Updated Dec. 30, 2014, 6:13 p.m.*
>  *Repository: * kalzium
> Description
>
> Kalzium CMakeLists.txt files updated to KF5
>
>   Testing
>
> cmake.. gives
>
> Configuration done.
> Generation done.
>
>   Diffs
>
>    - compoundviewer/CMakeLists.txt (0971248)
>    - compoundviewer/widgets/CMakeLists.txt (32f200a)
>    - data/icons/CMakeLists.txt (779ced5)
>    - data/icons/hi16-actions-calculate.png (PRE-CREATION)
>    - data/icons/hi16-actions-chemical.png (PRE-CREATION)
>    - data/icons/hi16-actions-elempic.png (PRE-CREATION)
>    - data/icons/hi16-actions-energies.png (PRE-CREATION)
>    - data/icons/hi16-actions-eqchem.png (PRE-CREATION)
>    - data/icons/hi16-actions-glossary.png (PRE-CREATION)
>    - data/icons/hi16-actions-isotopemap.png (PRE-CREATION)
>    - data/icons/hi16-actions-kalzium_molviewer.png (PRE-CREATION)
>    - data/icons/hi16-actions-kalzium_rs.png (PRE-CREATION)
>    - data/icons/hi16-actions-kalzium_tables.png (PRE-CREATION)
>    - data/icons/hi16-actions-legend.png (PRE-CREATION)
>    - data/icons/hi16-actions-misc.png (PRE-CREATION)
>    - data/icons/hi16-actions-numbers.png (PRE-CREATION)
>    - data/icons/hi16-actions-orbits.png (PRE-CREATION)
>    - data/icons/hi16-actions-overview.png (PRE-CREATION)
>    - data/icons/hi16-actions-plot.png (PRE-CREATION)
>    - data/icons/hi16-actions-sidebar.png (PRE-CREATION)
>    - data/icons/hi16-actions-spectrum.png (PRE-CREATION)
>    - data/icons/hi16-actions-statematter.png (PRE-CREATION)
>    - data/icons/hi16-actions-timeline.png (PRE-CREATION)
>    - data/icons/hi16-actions-tooltip.png (PRE-CREATION)
>    - data/icons/hi22-actions-calculate.png (PRE-CREATION)
>    - data/icons/hi22-actions-chemical.png (PRE-CREATION)
>    - data/icons/hi22-actions-elempic.png (PRE-CREATION)
>    - data/icons/hi22-actions-energies.png (PRE-CREATION)
>    - data/icons/hi22-actions-eqchem.png (PRE-CREATION)
>    - data/icons/hi22-actions-glossary.png (PRE-CREATION)
>    - data/icons/hi22-actions-isotopemap.png (PRE-CREATION)
>    - data/icons/hi22-actions-kalzium_molviewer.png (PRE-CREATION)
>    - data/icons/hi22-actions-kalzium_rs.png (PRE-CREATION)
>    - data/icons/hi22-actions-kalzium_tables.png (PRE-CREATION)
>    - data/icons/hi22-actions-legend.png (PRE-CREATION)
>    - data/icons/hi22-actions-numbers.png (PRE-CREATION)
>    - data/icons/hi22-actions-orbits.png (PRE-CREATION)
>    - data/icons/hi22-actions-overview.png (PRE-CREATION)
>    - CMakeLists.txt (f4ab27b)
>    - KalziumConfigureChecks.cmake (e3197ac)
>    - data/icons/hi22-actions-plot.png (PRE-CREATION)
>    - data/icons/hi22-actions-sidebar.png (PRE-CREATION)
>    - data/icons/hi22-actions-spectrum.png (PRE-CREATION)
>    - data/icons/hi22-actions-statematter.png (PRE-CREATION)
>    - data/icons/hi22-actions-timeline.png (PRE-CREATION)
>    - data/icons/hi22-actions-tooltip.png (PRE-CREATION)
>    - data/icons/hi32-actions-calculate.png (PRE-CREATION)
>    - data/icons/hi32-actions-chemical.png (PRE-CREATION)
>    - data/icons/hi32-actions-elempic.png (PRE-CREATION)
>    - data/icons/hi32-actions-energies.png (PRE-CREATION)
>    - data/icons/hi32-actions-eqchem.png (PRE-CREATION)
>    - data/icons/hi32-actions-glossary.png (PRE-CREATION)
>    - data/icons/hi32-actions-isotopemap.png (PRE-CREATION)
>    - data/icons/hi32-actions-kalzium_molviewer.png (PRE-CREATION)
>    - data/icons/hi32-actions-kalzium_rs.png (PRE-CREATION)
>    - data/icons/hi32-actions-kalzium_tables.png (PRE-CREATION)
>    - data/icons/hi32-actions-legend.png (PRE-CREATION)
>    - data/icons/hi32-actions-misc.png (PRE-CREATION)
>    - data/icons/hi32-actions-numbers.png (PRE-CREATION)
>    - data/icons/hi32-actions-orbits.png (PRE-CREATION)
>    - data/icons/hi32-actions-overview.png (PRE-CREATION)
>    - data/icons/hi32-actions-plot.png (PRE-CREATION)
>    - data/icons/hi32-actions-sidebar.png (PRE-CREATION)
>    - data/icons/hi32-actions-spectrum.png (PRE-CREATION)
>    - data/icons/hi32-actions-statematter.png (PRE-CREATION)
>    - data/icons/hi32-actions-timeline.png (PRE-CREATION)
>    - data/icons/hi32-actions-tooltip.png (PRE-CREATION)
>    - data/icons/hi48-actions-calculate.png (PRE-CREATION)
>    - data/icons/hi48-actions-chemical.png (PRE-CREATION)
>    - data/icons/hi48-actions-energies.png (PRE-CREATION)
>    - data/icons/hi48-actions-eqchem.png (PRE-CREATION)
>    - data/icons/hi48-actions-glossary.png (PRE-CREATION)
>    - data/icons/hi48-actions-isotopemap.png (PRE-CREATION)
>    - data/icons/hi48-actions-kalzium_molviewer.png (PRE-CREATION)
>    - data/icons/hi48-actions-kalzium_rs.png (PRE-CREATION)
>    - data/icons/hi48-actions-kalzium_tables.png (PRE-CREATION)
>    - data/icons/hi48-actions-legend.png (PRE-CREATION)
>    - data/icons/hi48-actions-misc.png (PRE-CREATION)
>    - data/icons/hi48-actions-numbers.png (PRE-CREATION)
>    - data/icons/hi48-actions-orbits.png (PRE-CREATION)
>    - data/icons/hi48-actions-overview.png (PRE-CREATION)
>    - data/icons/hi48-actions-plot.png (PRE-CREATION)
>    - data/icons/hi48-actions-sidebar.png (PRE-CREATION)
>    - data/icons/hi48-actions-spectrum.png (PRE-CREATION)
>    - data/icons/hi48-actions-statematter.png (PRE-CREATION)
>    - data/icons/hi48-actions-timeline.png (PRE-CREATION)
>    - data/icons/hi48-actions-tooltip.png (PRE-CREATION)
>    - data/icons/hi64-actions-kalzium_molviewer.png (PRE-CREATION)
>    - data/icons/hi64-actions-kalzium_rs.png (PRE-CREATION)
>    - data/icons/hi64-actions-kalzium_tables.png (PRE-CREATION)
>    - data/icons/hi64-actions-numbers.png (PRE-CREATION)
>    - data/icons/hisc-actions-calculate.svgz (PRE-CREATION)
>    - data/icons/hisc-actions-chemical.svgz (PRE-CREATION)
>    - data/icons/hisc-actions-elempic.svgz (PRE-CREATION)
>    - data/icons/hisc-actions-energies.svgz (PRE-CREATION)
>    - data/icons/hisc-actions-eqchem.svgz (PRE-CREATION)
>    - data/icons/hisc-actions-glossary.svgz (PRE-CREATION)
>    - data/icons/hisc-actions-isotopemap.svgz (PRE-CREATION)
>    - data/icons/hisc-actions-kalzium_molviewer.svgz (PRE-CREATION)
>    - data/icons/hisc-actions-kalzium_rs.svgz (PRE-CREATION)
>    - data/icons/hisc-actions-kalzium_tables.svgz (PRE-CREATION)
>    - data/icons/hisc-actions-misc.svgz (PRE-CREATION)
>    - data/icons/hisc-actions-numbers.svgz (PRE-CREATION)
>    - data/icons/hisc-actions-orbits.svgz (PRE-CREATION)
>    - data/icons/hisc-actions-overview.svgz (PRE-CREATION)
>    - data/icons/hisc-actions-plot.svgz (PRE-CREATION)
>    - data/icons/hisc-actions-sidebar.svgz (PRE-CREATION)
>    - data/icons/hisc-actions-spectrum.svgz (PRE-CREATION)
>    - data/icons/hisc-actions-statematter.svgz (PRE-CREATION)
>    - data/icons/hisc-actions-timeline.svgz (PRE-CREATION)
>    - data/icons/hisc-actions-tooltip.svgz (PRE-CREATION)
>    - doc/CMakeLists.txt (f04a92b)
>    - libscience/CMakeLists.txt (ac66132)
>    - libscience/tests/CMakeLists.txt (21c4f85)
>    - plasmoid/applet/bodr/CMakeLists.txt (e3ed33e)
>    - plasmoid/applet/concentrationPlasmoid/CMakeLists.txt (32ea556)
>    - plasmoid/applet/didyouknow/CMakeLists.txt (f6ca9e3)
>    - plasmoid/applet/gasPlasmoid/CMakeLists.txt (7d199bb)
>    - plasmoid/applet/nuclearPlasmoid/CMakeLists.txt (4acfab6)
>    - plasmoid/applet/psePlasmoid/CMakeLists.txt (58da62f)
>    - plasmoid/engine/CMakeLists.txt (534a56d)
>    - src/CMakeLists.txt (3cefc58)
>
> View Diff <https://git.reviewboard.kde.org/r/121758/diff/>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150102/cee1da6e/attachment-0001.html>