Review Request 121750: Remove phonon dependency. Use QtMultimedia in qml instead for sounds. Move sound files to src/ui/sounds and install them with the other qml files.

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121750/#review72892
-----------------------------------------------------------


+1
I'd like this to go in, regardless of what I said about Phonon, this definitely looks like a step forward.

- Aleix Pol Gonzalez


On Jan. 1, 2015, 2:02 p.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121750/
> -----------------------------------------------------------
> 
> (Updated Jan. 1, 2015, 2:02 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: kanagram
> 
> 
> Description
> -------
> 
> Remove phonon dependency. Use QtMultimedia in qml instead for sounds. Move sound files to src/ui/sounds and install them with the other qml files.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 5b847b98eb17cf8f846f3327324c6dae54e1ef12 
>   changes PRE-CREATION 
>   sounds/CMakeLists.txt eb03a902fedde15fb9ebac8d623c77001f42559b 
>   sounds/chalk.ogg  
>   sounds/chalk.wav  
>   sounds/right.ogg  
>   sounds/right.wav  
>   sounds/wrong.ogg  
>   sounds/wrong.wav  
>   src/CMakeLists.txt b8628fdf7d82068b4c4d59479662a3fc36cef3fc 
>   src/kanagramgame.h e9564cfcc6a19a3ed5e63db5340cd19a760914d5 
>   src/kanagramgame.cpp e0b60866ef49af3f28161c72982b17c6865f88ef 
>   src/ui/main.qml 38408ae66772a578a45faeb92ff9828f7c174f2a 
> 
> Diff: https://git.reviewboard.kde.org/r/121750/diff/
> 
> 
> Testing
> -------
> 
> Sounds still work as expected when Use Sounds is checked in preferences. Required some gst plugins locally, but that's an acceptable runtime requirement imo.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150102/46622fc0/attachment.html>