Review Request 121789: More cleanup of cpp code this time.

Jeremy Whiting jpwhiting at
Fri Jan 2 01:54:51 UTC 2015

This is an automatically generated e-mail. To reply, visit:

Review request for KDE Edu and Rahul Chowdhury.

Repository: khangman


Remove duplicate variables for word and current answer.
Rename setLanguage to scanLanguages to explain what it does.
Clean up includes in khangman.cpp.
Initialize m_currentLanguage and m_currentCategory.
Remove level concept, since we use category everywhere instead.
Remove unused private variables.
Add handling of ' - space and middot characters as the old desktop code had.
Remove a couple settings we no longer need or use.


  src/khangman.h 13f2b1696e39a7c0b3db8e86755a2e9a1630220d 
  src/khangman.cpp 1e8e923a1175643ea190405d088d14ca26ffa004 
  src/khangman.kcfg 44bf6fe209140cb358b97c4b9c96a2c8651be8fa 
  src/qml/GamePage.qml 517673226d80dc3f491d3f7e51436f2f534f8989 



It builds, runs and no longer crashes on start when there's no ~/.config/khangmanrc file.


Jeremy Whiting

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-edu mailing list