Review Request 121778: Bug Fix 342020 : When hover on legends of Periodic Table the elements belonging to that group fade out.

[Etienne Rebetez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121778/#review72883
-----------------------------------------------------------


I like it. Just two minor comments I like to raise.


src/legendwidget.cpp
<https://git.reviewboard.kde.org/r/121778/#comment50743>

    Instead of the "magic number" 0 you should use the enum, defined in kalziumelementproperty->SPECIALGRADIENTYPDEF.
    This would also remove the need to add comments.



src/legendwidget.cpp
<https://git.reviewboard.kde.org/r/121778/#comment50744>

    You actually only need to check for the element border color.


- Etienne Rebetez


On Jan. 1, 2015, 12:58 p.m., Shalin Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121778/
> -----------------------------------------------------------
> 
> (Updated Jan. 1, 2015, 12:58 p.m.)
> 
> 
> Review request for KDE Edu and Etienne Rebetez.
> 
> 
> Repository: kalzium
> 
> 
> Description
> -------
> 
> Fixed the color scheme of elements in periodic table when hovered over the legend of their group.
> 
> 
> Diffs
> -----
> 
>   src/legendwidget.cpp b0a7ba0 
> 
> Diff: https://git.reviewboard.kde.org/r/121778/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Shalin Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150101/c1c3721c/attachment-0001.html>