Review Request 121784: More qml cleanup.

Jeremy Whiting jpwhiting at kde.org
Thu Jan 1 20:31:40 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121784/
-----------------------------------------------------------

(Updated Jan. 1, 2015, 8:31 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Edu and Rahul Chowdhury.


Repository: khangman


Description
-------

Remove old comment lines.
Remove reference to deleted UIConstants.js file.
Make game ui visibility tied to isPlaying (except timer) so we don't need
  to keep setting visibility back and forth when pause/playing.
Make gallows visibility tied to isPlaying and if the counter > 0.


Diffs
-----

  src/qml/GamePage.qml 086b20e07cae0dae1b04ea47d16bffba1ca532df 
  src/qml/MySelectionDialog.qml 842f00811786342fdd53d74982d7e712b9fedd52 

Diff: https://git.reviewboard.kde.org/r/121784/diff/


Testing
-------

It still runs and works fine.


Thanks,

Jeremy Whiting

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150101/72418f7b/attachment.html>


More information about the kde-edu mailing list