Review Request 121778: Bug Fix 342020 : When hover on legends of Periodic Table the elements belonging to that group fade out.

Shalin Shah shalinshah1993 at gmail.com
Thu Jan 1 12:59:01 UTC 2015



> On Jan. 1, 2015, 12:41 p.m., Jeremy Whiting wrote:
> > src/legendwidget.cpp, line 29
> > <https://git.reviewboard.kde.org/r/121778/diff/1/?file=337644#file337644line29>
> >
> >     Please remove this include, you're not requiring it in the code you've added.

Yes, you're right it is not used anywhere. I added it for debugging purpose.


- Shalin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121778/#review72856
-----------------------------------------------------------


On Jan. 1, 2015, 12:58 p.m., Shalin Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121778/
> -----------------------------------------------------------
> 
> (Updated Jan. 1, 2015, 12:58 p.m.)
> 
> 
> Review request for KDE Edu and Etienne Rebetez.
> 
> 
> Repository: kalzium
> 
> 
> Description
> -------
> 
> Fixed the color scheme of elements in periodic table when hovered over the legend of their group.
> 
> 
> Diffs
> -----
> 
>   src/legendwidget.cpp b0a7ba0 
> 
> Diff: https://git.reviewboard.kde.org/r/121778/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Shalin Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150101/bb03dff0/attachment.html>


More information about the kde-edu mailing list