Review Request 122581: [klettres] Do not depend on kdelibs4support

[Albert Astals Cid]

> On feb. 15, 2015, 11:54 p.m., Aleix Pol Gonzalez wrote:
> > src/CMakeLists.txt, line 25
> > <https://git.reviewboard.kde.org/r/122581/diff/1/?file=349848#file349848line25>
> >
> >     Use ecm_add_app_icon in ECMAddAppIcon.cmake.
> 
> Christoph Feck wrote:
>     I just noticed that this is brand new in ECM 1.7.0. Can we already depend on it?

Well, it's using a released thing on an unreleased branch, i'd say sure.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122581/#review76090
-----------------------------------------------------------


On feb. 15, 2015, 7:53 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122581/
> -----------------------------------------------------------
> 
> (Updated feb. 15, 2015, 7:53 p.m.)
> 
> 
> Review request for KDE Edu and Laurent Navet.
> 
> 
> Repository: klettres
> 
> 
> Description
> -------
> 
> No idea if kde4_add_app_icon has a replacement in KF5. It seems to be commented everywhere.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt acf1071 
>   src/CMakeLists.txt 8e07c51 
> 
> Diff: https://git.reviewboard.kde.org/r/122581/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150222/3d62d6a8/attachment.html>