Review Request 122581: [klettres] Do not depend on kdelibs4support

Aleix Pol Gonzalez aleixpol at kde.org
Sun Feb 15 23:54:51 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122581/#review76090
-----------------------------------------------------------



src/CMakeLists.txt
<https://git.reviewboard.kde.org/r/122581/#comment52505>

    Use ecm_add_app_icon in ECMAddAppIcon.cmake.


- Aleix Pol Gonzalez


On Feb. 15, 2015, 8:53 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122581/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2015, 8:53 p.m.)
> 
> 
> Review request for KDE Edu and Laurent Navet.
> 
> 
> Repository: klettres
> 
> 
> Description
> -------
> 
> No idea if kde4_add_app_icon has a replacement in KF5. It seems to be commented everywhere.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt acf1071 
>   src/CMakeLists.txt 8e07c51 
> 
> Diff: https://git.reviewboard.kde.org/r/122581/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150215/d76266f6/attachment-0001.html>


More information about the kde-edu mailing list