Review Request 122557: Add KDELibs4ConfigMigrator support to Cantor

[Filipe Saraiva]

> On Fev. 13, 2015, 1:14 p.m., Jeremy Whiting wrote:
> > Ship It!
> 
> Jeremy Whiting wrote:
>     One thing I noticed, you added CoreAddons to the target link libraries, but didn't need to add it to the find_package, since it was already there. Maybe need to check if all the KF5 stuff in find_package is still used and remove any that aren't :)

You are right, this work needs to be done.


- Filipe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122557/#review75989
-----------------------------------------------------------


On Fev. 13, 2015, 8:27 a.m., Filipe Saraiva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122557/
> -----------------------------------------------------------
> 
> (Updated Fev. 13, 2015, 8:27 a.m.)
> 
> 
> Review request for KDE Edu, Alexander Rieder, Lucas Hermann Negri, and Minh Ngo.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> Migrating the config file of Cantor 4.x version to Cantor KF5-based version, following the tips in [https://community.kde.org/Frameworks/Porting_Notes#Migrating_configuration](https://git.reviewboard.kde.org/r/122557/)
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 9c69f58 
>   src/main.cpp f5ba473 
> 
> Diff: https://git.reviewboard.kde.org/r/122557/diff/
> 
> 
> Testing
> -------
> 
> 1. Delete cantorrc of KF5 applications config folder (XDG_*_HOME) - in my case, ~/.config/cantorrc;
> 2. Open Cantor 4.x version and insert different settings to different backends in Settings > Configure Cantor; change the size and position of the main window and some assistant windows; close it.
> 3. Open Cantor KF5 version and verify if the settings of Cantor 4.x were imported to Cantor KF5 (in my case, yes).
> 
> 
> Thanks,
> 
> Filipe Saraiva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150213/ff06b14f/attachment-0001.html>