Review Request 122443: Add VocabularyModel

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122443/#review75536
-----------------------------------------------------------

Ship it!


Ok, Aside from one really big issue, I think it's ready for merge if you just fix them before the actual commit.  That issue is that there should be no data members in the main class, that's what the private class is for.  Well, and the build issue, of course.


keduvocdocument/CMakeLists.txt
<https://git.reviewboard.kde.org/r/122443/#comment52235>

    You should either remove or disable these in the cmake file until they are actually added to the repository. Otherwise the repo won't build for people other than you.



keduvocdocument/CMakeLists.txt
<https://git.reviewboard.kde.org/r/122443/#comment52236>

    and same here.



keduvocdocument/keduvocvocabularymodel.h
<https://git.reviewboard.kde.org/r/122443/#comment52237>

    These should be removed.



keduvocdocument/keduvocvocabularymodel.h
<https://git.reviewboard.kde.org/r/122443/#comment52238>

    remove



keduvocdocument/keduvocvocabularymodel.h
<https://git.reviewboard.kde.org/r/122443/#comment52240>

    Wait, these were supposed to go into the private class!  That was the whole point of it, namely to have no data members in the main class.



keduvocdocument/keduvocvocabularymodel.cpp
<https://git.reviewboard.kde.org/r/122443/#comment52239>

    remove



keduvocdocument/keduvocvocabularymodel.cpp
<https://git.reviewboard.kde.org/r/122443/#comment52241>

    remove



keduvocdocument/keduvocvocabularymodel.cpp
<https://git.reviewboard.kde.org/r/122443/#comment52242>

    remove


- Inge Wallin


On Feb. 6, 2015, 4:42 p.m., Rahul Chowdhury wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122443/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2015, 4:42 p.m.)
> 
> 
> Review request for KDE Edu and Inge Wallin.
> 
> 
> Repository: libkeduvocdocument
> 
> 
> Description
> -------
> 
> Add a new KEduVocVocabularyModel class from Parley and change all code related to Parley and Prefs.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 44e1950 
>   keduvocdocument/CMakeLists.txt 6eeba12 
>   keduvocdocument/keduvocvocabularymodel.h PRE-CREATION 
>   keduvocdocument/keduvocvocabularymodel.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122443/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rahul Chowdhury
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150206/a1ee7b74/attachment-0001.html>