Review Request 122443: Add VocabularyModel

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122443/#review75482
-----------------------------------------------------------


Looks good in general. See the small issues below.  But there is one important thing left: the d-pointer.


keduvocdocument/keduvocvocabularymodel.h
<https://git.reviewboard.kde.org/r/122443/#comment52195>

    This is a slightly cumbersome name.  I think a simple recursive() and setRecursive() as a setter would be clear enough.



keduvocdocument/keduvocvocabularymodel.h
<https://git.reviewboard.kde.org/r/122443/#comment52196>

    This should removed.  It has nothing to do with the model itself, but is an old thing from the parley application.



keduvocdocument/keduvocvocabularymodel.h
<https://git.reviewboard.kde.org/r/122443/#comment52197>

    This is good enough for an application.  But for a library, you must introduce a d-pointer to guarantee future binary compatibility.  
    
    See any other class in keduvocdocument for how this is done.



keduvocdocument/keduvocvocabularymodel.cpp
<https://git.reviewboard.kde.org/r/122443/#comment52198>

    Remove



keduvocdocument/keduvocvocabularymodel.cpp
<https://git.reviewboard.kde.org/r/122443/#comment52199>

    Remove



keduvocdocument/keduvocvocabularymodel.cpp
<https://git.reviewboard.kde.org/r/122443/#comment52200>

    disable (comment out) or remove.


- Inge Wallin


On Feb. 5, 2015, 5:14 p.m., Rahul Chowdhury wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122443/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2015, 5:14 p.m.)
> 
> 
> Review request for KDE Edu and Inge Wallin.
> 
> 
> Repository: libkeduvocdocument
> 
> 
> Description
> -------
> 
> Add a new KEduVocVocabularyModel class from Parley and change all code related to Parley and Prefs.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 44e1950 
>   keduvocdocument/CMakeLists.txt 6eeba12 
>   keduvocdocument/keduvocvocabularymodel.h PRE-CREATION 
>   keduvocdocument/keduvocvocabularymodel.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122443/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rahul Chowdhury
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150205/9775517b/attachment.html>