Review Request 122406: Initial port of KUrl to QUrl

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122406/#review75315
-----------------------------------------------------------


+1

Looks straightforward. Have you tested it?

- Aleix Pol Gonzalez


On Feb. 3, 2015, 3:57 p.m., Lucas Hermann Negri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122406/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2015, 3:57 p.m.)
> 
> 
> Review request for KDE Edu, Alexander Rieder, Filipe Saraiva, and Minh Ngo.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> Initial port of **KUrl** to **QUrl**. Touched many files as it is like a *domino effect*. It is not just a search/replace, as the semantics and API have changed.
> 
> In the process also re-enabled the latex rendering in latex/text entries.
> 
> 
> Diffs
> -----
> 
>   src/backends/R/rbackend.h 5eae64f 
>   src/backends/R/rbackend.cpp 3d95c79 
>   src/backends/R/rexpression.cpp f0f9abd 
>   src/backends/lua/luabackend.h a590840 
>   src/backends/lua/luabackend.cpp 3e25c77 
>   src/backends/lua/luaexpression.cpp 7e16454 
>   src/backends/maxima/maximabackend.h 3139c0e 
>   src/backends/maxima/maximabackend.cpp 4cb4acb 
>   src/backends/maxima/maximaexpression.cpp 14a5b59 
>   src/backends/null/nullexpression.cpp 2f2994d 
>   src/backends/octave/octavebackend.h da98bbb 
>   src/backends/octave/octavebackend.cpp 7c40d88 
>   src/backends/octave/octaveexpression.cpp 44426ce 
>   src/backends/python/pythonexpression.cpp 83a502a 
>   src/backends/python2/python2backend.h 4dcad25 
>   src/backends/python2/python2backend.cpp 1f16665 
>   src/backends/python3/python3backend.h 3930d88 
>   src/backends/python3/python3backend.cpp bfd00ba 
>   src/backends/qalculate/qalculatebackend.h 72a948e 
>   src/backends/qalculate/qalculatebackend.cpp 272fe3a 
>   src/backends/qalculate/qalculateexpression.cpp 1891baa 
>   src/backends/sage/sagebackend.h 74d0ff9 
>   src/backends/sage/sagebackend.cpp 57c7265 
>   src/backends/sage/sageexpression.cpp 5aaeaa4 
>   src/backends/scilab/scilabbackend.h 12f621a 
>   src/backends/scilab/scilabbackend.cpp d28e42f 
>   src/backends/scilab/scilabexpression.cpp c91ccf9 
>   src/cantor.h c703f5d 
>   src/cantor.cpp 5194fc7 
>   src/cantor_part.cpp 88ca911 
>   src/epsrenderer.h 6184cc5 
>   src/epsrenderer.cpp fd05f53 
>   src/imageentry.cpp 7ae264d 
>   src/imageresultitem.cpp 77bc20e 
>   src/latexentry.cpp 0671243 
>   src/lib/animationresult.h ddf42c8 
>   src/lib/animationresult.cpp 2572ef7 
>   src/lib/backend.h ca884ae 
>   src/lib/backend.cpp 101ff74 
>   src/lib/epsresult.h cd636e7 
>   src/lib/epsresult.cpp 97e29c0 
>   src/lib/expression.cpp 345198a 
>   src/lib/imageresult.h 8b9dde1 
>   src/lib/imageresult.cpp dbb5542 
>   src/lib/latexresult.h 8970668 
>   src/lib/latexresult.cpp 2b830de 
>   src/lib/result.h 5aec2e5 
>   src/lib/result.cpp e0f8d20 
>   src/loadedexpression.cpp 702b937 
>   src/panelplugins/variablemgr/variablemanagerwidget.cpp fc8551b 
>   src/textentry.cpp 1d1484a 
>   src/textresultitem.cpp 6ffeab0 
>   src/worksheetimageitem.h dc76d90 
>   src/worksheetimageitem.cpp a024be7 
>   src/animationresultitem.cpp 11d227a 
>   src/assistants/runscript/runscriptassistant.cpp c749e2a 
> 
> Diff: https://git.reviewboard.kde.org/r/122406/diff/
> 
> 
> Testing
> -------
> 
> Tested the functionality that used urls, like the help button, latex rendering, plotting, save/load worksheet and variables, export.
> 
> Seems to be working, but apart from the latex rendering (epsrendering actually), this is not an urgent patch and can wait more testing for a future release, I think.
> 
> 
> Thanks,
> 
> Lucas Hermann Negri
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150203/267740a7/attachment-0001.html>