Review Request 122248: Fixing the crash during autocompletion

[Minh Ngo]

> On Jan. 30, 2015, 7:05 p.m., Filipe Saraiva wrote:
> > Hi Minh, unfortunately I am getting the same error when I follow your testing suggestion. Can not you to replicate this error?

Okay, looks like you have fixed this bug. Good job! I'm closing this request then.


- Minh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122248/#review75054
-----------------------------------------------------------


On Jan. 25, 2015, 4:59 p.m., Minh Ngo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122248/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2015, 4:59 p.m.)
> 
> 
> Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.
> 
> 
> Bugs: 342888
>     http://bugs.kde.org/show_bug.cgi?id=342888
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> Fixes the crash during autocompletion.
> 
> This crash happened before possibly because you didn't select any item from the completion list before pressing '.'. And then because of some logic it decided that you don't need m_completionObject anymore and delete it.
> 
> Detailed stack trace is in the bug ticket.
> 
> I'm selecting the first item after pressing tab to avoid this problem. Looks like all is working now like an user expects.
> 
> 
> Diffs
> -----
> 
>   src/commandentry.cpp 7b7c657 
> 
> Diff: https://git.reviewboard.kde.org/r/122248/diff/
> 
> 
> Testing
> -------
> 
> 1. Select some backend (for example, Python 2);
> 2. Type "num" (without ") and press TAB;
> 3. Press "." (without ");
> 
> 
> Thanks,
> 
> Minh Ngo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150203/7bd46e8a/attachment.html>