Review Request 122357: Port Away from KStandardDirs in Type Loading/Saving

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122357/#review75122
-----------------------------------------------------------



kig/kig_part.cpp
<https://git.reviewboard.kde.org/r/122357/#comment51976>

    const QString&



kig/kig_part.cpp
<https://git.reviewboard.kde.org/r/122357/#comment51977>

    this second hasNext looks redundant.



kig/kig_part.cpp
<https://git.reviewboard.kde.org/r/122357/#comment51978>

    If it's not a local path it will already return QString(), no?



kig/kig_part.cpp
<https://git.reviewboard.kde.org/r/122357/#comment51979>

    I think you want QStandardPaths::writableLocation there.


- Aleix Pol Gonzalez


On Feb. 1, 2015, 8:57 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122357/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2015, 8:57 a.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: kig
> 
> 
> Description
> -------
> 
> Now using QStandardPaths to load built-in macros and regular macros from respective files.
> 
> 
> Diffs
> -----
> 
>   kig/kig_part.cpp 1cfb0e2 
> 
> Diff: https://git.reviewboard.kde.org/r/122357/diff/
> 
> 
> Testing
> -------
> 
> 1. Created new macros
> 2. Verified macros were saved across application restart
> 3. Deleted created macros
> 4. Verified macros were deleted across application restart
> 5. Verified that built-in macros (e.g. square construction) are loaded
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150201/7aab548f/attachment.html>