Review Request 126279: Fix Bug 356233: Call saveAs setting file type to Kvtml and transform url to local file format

[Andreas Cord-Landwehr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126279/#review90358
-----------------------------------------------------------


Thanks for you work. Yet, the approach in this patch is not correct, since it exploits casting strangeness between QString and QUrl. I just pushed 0cb9b9aea2264fc66d25fb6d93adc32c75dfef97 which should be a proper fix to this bug by fixing the wrong use of urls instead of paths for file system operations in the saveAs method.
So the review request can be discarded.

- Andreas Cord-Landwehr


On Dez. 30, 2015, 12:38 nachm., Dimitris Kardarakos wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126279/
> -----------------------------------------------------------
> 
> (Updated Dez. 30, 2015, 12:38 nachm.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Bugs: 356233
>     http://bugs.kde.org/show_bug.cgi?id=356233
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> Fix "Bug 356233 - File is not writeable when creating a new collection" by calling saveAs setting file type to Kvtml and transforming url to local file format
> 
> 
> Diffs
> -----
> 
>   src/parleydocument.cpp edda984 
> 
> Diff: https://git.reviewboard.kde.org/r/126279/diff/
> 
> 
> Testing
> -------
> 
> Applying this patch in conjunction with removing plugins/google_images.desktop after installation (as a workaround to bug 356104) I have managed to create and save new vocabulary collections (bug 356233).
> 
> Tests:
> 1. Create new collection - Use "Save" functionality
> 2. Create new collection - Use "Save As" functionality
> 3. Create new collection - Leave without saving - Message displayed - Save
> 
> 
> Thanks,
> 
> Dimitris Kardarakos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20151230/cf932560/attachment.html>