Review Request 126306: Fix errror with 'break' statement out of context in PHP 7

Filipe Saraiva filipe at kde.org
Sat Dec 12 13:44:08 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126306/
-----------------------------------------------------------

(Updated Dec. 12, 2015, 1:44 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Edu and Andreas Cord-Landwehr.


Changes
-------

Submitted with commit 6ae6c6679af184270a5a1bc16dc341746f850d10 by Albert Astals Cid on behalf of Filipe Saraiva to branch master.


Repository: edu-kde-org


Description
-------

PHP 7 introduces an error when `break` is utilized out of `switch` or `loop` context. The patch fixes this error.


Diffs
-----

  site_includes/class_submenu.inc 790e1a2 

Diff: https://git.reviewboard.kde.org/r/126306/diff/


Testing
-------

If I run the current code in an Apache server with PHP 7, I get the follow error:

```[Thu Dec 10 16:21:36 2015] PHP Fatal error:  'break' not in the 'loop' or 'switch' context in /home/kdevil/kdesrc/websites/edu-kde-org/site_includes/class_submenu.inc on line 31```
```[Thu Dec 10 16:21:36 2015] 127.0.0.1:55496 [500]: / - 'break' not in the 'loop' or 'switch' context in /home/kdevil/kdesrc/websites/edu-kde-org/site_includes/class_submenu.inc on line 31```

After the fix, I could to run the website correctly.


Thanks,

Filipe Saraiva

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20151212/2198914f/attachment.html>


More information about the kde-edu mailing list