Review Request 124849: Don't use "apps" directory when installing kvtml data

Jeremy Whiting jpwhiting at kde.org
Thu Aug 20 21:59:34 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124849/#review84119
-----------------------------------------------------------


Yes, we did that so both libkdeedu using (Qt4/kdelibs based khangman) and libkeduvocdocument (kanagram, kwordquiz) used the apps/kvtml path, but all applications have been ported by now. Though I do wonder if it wouldn't be easier to just make knewstuff download to share/apps/kvtml instead of share/kvtml so anyone with existing data from a libkdeedu install can keep using those files.

- Jeremy Whiting


On Aug. 20, 2015, 2:50 p.m., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124849/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2015, 2:50 p.m.)
> 
> 
> Review request for KDE Edu and Jeremy Whiting.
> 
> 
> Repository: kdeedu-data
> 
> 
> Description
> -------
> 
> It shouldn't be used anymore because of the transition from from
> KStandardDirs to QStandardPaths, according to
> https://mail.kde.org/pipermail/kde-frameworks-devel/2013-November/008086.html
> 
> 
> Diffs
> -----
> 
>   data/kvtml/CMakeLists.txt 905f1c5 
> 
> Diff: https://git.reviewboard.kde.org/r/124849/diff/
> 
> 
> Testing
> -------
> 
> Vocabularies installed by kdeedu-data now show up in kanagram.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150820/70be8a5c/attachment.html>


More information about the kde-edu mailing list