Review Request 124829: Fix building the qalculate backend

Heiko Becker heirecka at exherbo.org
Thu Aug 20 20:49:38 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124829/
-----------------------------------------------------------

(Updated Aug. 20, 2015, 8:49 nachm.)


Review request for KDE Edu and Filipe Saraiva.


Changes
-------

Updated summary and description. Somehow I attributed that failure to gcc-5, I thought I had built it successfully before with an older version.


Summary (updated)
-----------------

Fix building the qalculate backend


Bugs: 350729
    http://bugs.kde.org/show_bug.cgi?id=350729


Repository: cantor


Description
-------

Thanks to Christoph Feck who suggested the fix. Also added a missing parenthesis.

BUG: 350729


Diffs
-----

  src/backends/qalculate/qalculateexpression.cpp a51d7fdbe304ef093d62ee736c9f446b791f9f95 

Diff: https://git.reviewboard.kde.org/r/124829/diff/


Testing (updated)
-------

Successfully built cantor with the qalculate backend.


Thanks,

Heiko Becker

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150820/2e89fee4/attachment.html>


More information about the kde-edu mailing list