Review Request 123553: Remove private customized KAutoSaveFile. If regressions from this are found, we need to fix them in the KCoreAddons framework.

Jeremy Whiting jpwhiting at kde.org
Wed Apr 29 00:22:07 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123553/
-----------------------------------------------------------

Review request for KDE Edu, Andreas Xavier and Inge Wallin.


Repository: libkeduvocdocument


Description
-------

Remove private customized KAutoSaveFile. If regressions from this are found, we need to fix them in the KCoreAddons framework.


Diffs
-----

  keduvocdocument/CMakeLists.txt aa81492e8996750c57a97c7c8c1f28c5153f0c57 
  keduvocdocument/autosave/kautosavefile.h b54eb6731ee895c9a33ca73d57a10057e49ace81 
  keduvocdocument/autosave/kautosavefile.cpp 3b691a5cc868e4ecbf46346ed2fc4fc9bad81ed2 
  keduvocdocument/autosave/kautosavefileprivate.h a86b2e2ef57df8316bcf7a54cc8396122935d1d6 
  keduvocdocument/autosave/kautosavefileprivate.cpp 38d49b4b1665cc57ff5f409470dc5771b549fcf3 
  keduvocdocument/autotests/CMakeLists.txt 98cd414509935da5f08428dcc04925d27389cbaa 
  keduvocdocument/autotests/kautosavefiletest.h 41e60b0082ca57034e1b523ba688937f60511ee1 
  keduvocdocument/autotests/kautosavefiletest.cpp 8838f6ffe57f4dc3d6353ba78686b2f15224739f 
  keduvocdocument/keduvocdocument.cpp 5b0df4c6f204fa5865d9fa051c88858b2b115597 

Diff: https://git.reviewboard.kde.org/r/123553/diff/


Testing
-------

Parley built with this still runs. I'm not sure what the problem is that the local copy changes are trying to solve. The patches to upstream those changes can be seen here: https://git.reviewboard.kde.org/r/121099 and https://git.reviewboard.kde.org/r/119530 for reference.


Thanks,

Jeremy Whiting

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150429/92330315/attachment.html>


More information about the kde-edu mailing list