Review Request 123394: FindLibSpectre: Use FindPkgConfig instead of UsePkgConfig

Heiko Becker heirecka at exherbo.org
Sun Apr 19 13:15:26 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123394/
-----------------------------------------------------------

(Updated April 19, 2015, 1:15 nachm.)


Review request for KDE Edu and Filipe Saraiva.


Changes
-------

Added an else branch to "if(not win32)" to handle windows.


Bugs: 346283
    http://bugs.kde.org/show_bug.cgi?id=346283


Repository: cantor


Description
-------

The latter is deprecated and doesn't respect the PKG_CONFIG
environment variable which makes it easy to deal with differently
named pkg-config executables, e.g. arch-prefixed ones.


Diffs (updated)
-----

  cmake/FindLibSpectre.cmake 8d5dc76 

Diff: https://git.reviewboard.kde.org/r/123394/diff/


Testing
-------

Configured and built cantor successfully and checked that it links to libspectre.


Thanks,

Heiko Becker

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150419/fea7dcda/attachment.html>


More information about the kde-edu mailing list